Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Broken images for Client's logos #2368

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixing Broken images for Client's logos #2368

merged 1 commit into from
Mar 26, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Mar 26, 2024

Affected Route: /
Fixed: #2362

Affected Route: `/`
Fixed: #2363
@amankumarrr amankumarrr changed the title Fixing - Broken images Fixing Broken images for Client's logos Mar 26, 2024
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.25% 69/27596
🔴 Branches 8.86% 24/271
🔴 Functions 1.2% 3/250
🔴 Lines 0.25% 69/27596

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from d96f95c

@amankumarrr amankumarrr enabled auto-merge (squash) March 26, 2024 06:57
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2368.azurewebsites.net

@amankumarrr amankumarrr merged commit 27dcb05 into main Mar 26, 2024
11 checks passed
@amankumarrr amankumarrr deleted the brand-logo-issue branch March 26, 2024 07:09
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 90
Best practices 96
Performance 40
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2368.azurewebsites.net

@wicksipedia
Copy link
Member

I think this should’ve been commented out with a TODO since it may be temporary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Homepage - Broken images
3 participants