Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline - Fixing main build for the coverage #2199

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Pipeline - Fixing main build for the coverage #2199

merged 6 commits into from
Feb 26, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Feb 25, 2024 •
edited
Loading

Fixed: #2129

Fixing the bug for production build and clean up for the coverage files.

image

Figure: Error on production pipeline

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 74
Performance 26
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 74
Performance 28.000000000000004
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 74
Performance 39
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 0.26% 69/26177
🔴 Branches 9.3% 24/258
🔴 Functions 1.27% 3/237
🔴 Lines 0.26% 69/26177

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from c569e50

@amankumarrr amankumarrr marked this pull request as ready for review February 26, 2024 01:51
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 74
Performance 35
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2199.azurewebsites.net

wicksipedia
wicksipedia approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - assuming we don’t need to got ignore the coverage files since they aren’t generated on dev machines

@amankumarrr amankumarrr merged commit 80dfff4 into main Feb 26, 2024
11 checks passed
@amankumarrr amankumarrr deleted the fix-coverage-summary branch February 26, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wicksipedia wicksipedia wicksipedia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧪 Test coverage
2 participants
@amankumarrr @wicksipedia