Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slots Cleanup - Adding new check #1211

Merged
merged 181 commits into from
Aug 17, 2023
Merged

Slots Cleanup - Adding new check #1211

merged 181 commits into from
Aug 17, 2023

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Aug 10, 2023

Fixes : #1175

  • Modified the pr-delete-close-env to make it a callable flow
  • Added new flow to clean up the slots every Monday day at 12 noon

Check Active PRs and Slots - Flow

  1. It fetches all the slots that are running under our AppService
  2. It fetches all the Active PRs from our repo
  3. It checks if we have any slot that is running and has not any active Pull Request
  4. Upon finding a slot that is running without a Pull Request, it calls the second flow pr-delete-close-env with an input of slot ids that need to be deleted
  5. If in step 3, it finds no slot running without a PR, it will skip the 4th step and terminate the flow

Impacted Flows:

pr-close-delete-env

This flow is now capable of handling the following triggers:

  1. Workflow_Dispatch
  2. Call from another flow
  3. On PR closed

All triggers can be handled either by giving single id or ids separated by space

Tested Scenarios:

✅ Manually triggered pr-close-delete-env flow for (Workflow_Dispatch)
✅ Rerun the flow after deleting the slots
✅ Ran the flow with multiple and single slot ids

image

Figure: Deleted 2 slots in parallel

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 91
Performance 34
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 57.99999999999999
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 91
Performance 37
SEO 100

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 91
Performance 32
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@github-actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 92
Best practices 95
Performance 33
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1211.azurewebsites.net

@amankumarrr amankumarrr merged commit 0beb2be into main Aug 17, 2023
9 checks passed
@amankumarrr amankumarrr deleted the adding-new-check branch August 17, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 WebApp Slots - Old PR slots are still running
2 participants