✨ New Components - User Group Sidebar Components #1118
Conversation
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
johnxu16
changed the title
johnxu16
force-pushed
the
1112_usergroup-sidebar-components
branch
2 times, most recently
from
af9d41e
to
1f1f860
Compare
components/blocks-renderer.tsx
Outdated
| Organizer: Organizer, | ||
| JoinGithub: JoinGithub, | ||
| JoinAsPresenter: JoinAsPresenter, |
There was a problem hiding this comment.
Why are these not formatted like the other ones?
There was a problem hiding this comment.
Checked component above Agenda: Agenda, thought it would be a new trend even if it is a bit redundant.
Done - Format changed
| </clipPath> | ||
| </defs> | ||
| {img ? ( | ||
| <image href={img} width={220} clipPath="url(#shape)"></image> |
There was a problem hiding this comment.
Why is this not using next/image or even just the <img> tag
There was a problem hiding this comment.
Since the image is clipped with the shape, if there is a better solution I'd love to refactor this part.
Love next/image for its performance!
Figure: clipPath on left bottom cornor
- Replace its with clip-path on image
Done - changed from <image /> in svg to nextjs
components/usergroup/joinGithub.tsx
Outdated
| <button | ||
| data-tina-field={tinaField(data, "link")} | ||
| onClick={() => window.open(data?.link ?? "", "_blank").focus} | ||
| className="h-12 w-max rounded-md bg-sswRed px-4 py-2 text-md leading-3 text-white" | ||
| > | ||
| Join the crowd | ||
| </button> |
There was a problem hiding this comment.
I'm not fully understand this.
What does the tag referring to? I may reach you tomorrow for this.
As per conversation with Harry, the has been changed into nextjs .
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
johnxu16
force-pushed
the
1112_usergroup-sidebar-components
branch
from
86d42ff
to
35a2eb4
Compare
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
johnxu16
force-pushed
the
1112_usergroup-sidebar-components
branch
from
35a2eb4
to
eea13d3
Compare
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
Harry-Ross
changed the title
johnxu16
force-pushed
the
1112_usergroup-sidebar-components
branch
from
0d1c640
to
22b9c9f
Compare
|
Deployed changes to https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-1118.azurewebsites.net |
Fixes #1112
Affected routes:
Add done video, screenshots
Figure: Overview of components
Figure: Component
<JoinGithub />Figure: Component
<Organizer />Figure: Component
<JoinAsPresenter />Figure: Demo content mocking on home.mdx`