Adding new false for consistency

SSWConsulting · Mar 29, 2024 · 762a8cc · 762a8cc
1 parent 8bf2ea3
commit 762a8cc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/daily-image-tests.yml b/.github/workflows/daily-image-tests.yml
@@ -48,17 +48,17 @@ jobs:
           echo "Test passed : ${{ needs.check-broken-images.outputs.testPassed }}"
           echo "Artifact Id: ${{ needs.check-broken-images.outputs.artifact-id }}"
           echo "Create Issue: ${{ env.create_issue }}"
-          echo "Test Pass condition: ${{ needs.check-broken-images.outputs.testPassed == 'False'}}"
-          echo "Condition: ${{ env.create_issue && needs.check-broken-images.outputs.testPassed == 'False'}}"
-          echo "create_issue=${{ env.create_issue }}'" >> $GITHUB_OUTPUT
+          echo "Test Pass condition: ${{ needs.check-broken-images.outputs.testPassed == 'false'}}"
+          echo "Condition: ${{ env.create_issue && needs.check-broken-images.outputs.testPassed == 'false'}}"
+          echo "create_issue='${{ env.create_issue }}'" >> $GITHUB_OUTPUT
 
   create-an-issue:
     name: GitHub Issue
     runs-on: ubuntu-latest
     needs:
       - check-broken-images
       - test-output
-    if: ${{ needs.test-output.outputs.create_issue && needs.check-broken-images.outputs.testPassed == 'False'}}
+    if: ${{ needs.test-output.outputs.create_issue == 'true' && needs.check-broken-images.outputs.testPassed == 'false'}}
     steps:
       - name: Playwright Artifact
         run: |

diff --git a/.github/workflows/template-ui-tests.yml b/.github/workflows/template-ui-tests.yml
@@ -64,7 +64,7 @@ jobs:
         if: failure() && steps.run.outcome == 'failure'
         run: |
           echo " This is output of preivous job: ${{ steps.run.outcome }}"
-          $testPassed='False'
+          $testPassed='false'
           echo "testPassed=$testPassed" >> $env:GITHUB_OUTPUT
 
       - name: Run on failure