Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end date field #596

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Add end date field #596

merged 3 commits into from
Aug 2, 2023

Conversation

jimmidier
Copy link
Collaborator

Closes #561

image
Figure: Emulated new calendar card

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (9d2ef12) 31.75% compared to head (ae9974c) 31.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          78       78           
  Lines        2201     2201           
=======================================
  Hits          699      699           
  Misses       1502     1502           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AttackOnMorty
Copy link
Member

Closes #561

image
Figure: Emulated new calendar card

This list actually shows the next 10 days' bookings. I think we should show something like the one below so that the end date can be meaningful.

image

@jimmidier
Copy link
Collaborator Author

@AttackOnMorty Done -
image
Figure: Before

image
Figure: After

Copy link
Member

@AttackOnMorty AttackOnMorty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmidier jimmidier merged commit 8b43155 into main Aug 2, 2023
@jimmidier jimmidier deleted the 561-new_fields_on_calendar_card branch August 2, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ New fields on Calendar card
3 participants