Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream-10-devel container #89

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

alexey-tikhonov
Copy link
Member

@alexey-tikhonov alexey-tikhonov commented Apr 16, 2024

Currently c10s support is being added with virt_smartcard: No until required deps are made available.

@alexey-tikhonov
Copy link
Member Author

@pbrezina , https://copr.fedorainfracloud.org/coprs/g/sssd/ci-deps/ got 'Centos-stream 10' but not 'EPEL 10'.
Why / how to enable EPEL10?

@pbrezina
Copy link
Member

Copr does not have epel10 chroot available at this moment, we will need to wait.

@pbrezina
Copy link
Member

pbrezina commented Apr 17, 2024

Or we can switch to centos10 when running dnf copr enable so we don't depend on epel.

@alexey-tikhonov
Copy link
Member Author

Or we can switch to centos10 when running dnf copr enable so we don't depend on epel.

In centos10 playbooks only?

@pbrezina
Copy link
Member

Or we can switch to centos10 when running dnf copr enable so we don't depend on epel.

In centos10 playbooks only?

Not necessarily, we can do it for all. It's just that copr enable defaults to epel on rhel/centos (maybe to save resources, I don't know). But we build it on all available chroots and the packages will be identical.

@alexey-tikhonov
Copy link
Member Author

- No package tmate available.

@alexey-tikhonov
Copy link
Member Author

hm... https://copr.fedorainfracloud.org/coprs/g/sssd/ci-deps/packages/ :: 'Last build status' is pretty "red"...

@alexey-tikhonov
Copy link
Member Author

Btw, why do we need 'tmate' and 'lcov' at all?

@pbrezina
Copy link
Member

Looks like there is issue with ppc64 - that will resolve on its own, I assume. tmate fails on all centos10 with No matching package to install: 'msgpack-devel >= 1.1.8' which is weird, since msgpack was built successfully on all but ppc64.

lcov was used for intg tests, I think we can drop it now.

tmate is useful when you want to share issues with team mate, but it is not needed for CI. I will look into it tomorrow and see if we can make it work. If not, we can drop it.

@pbrezina
Copy link
Member

Ok, tmate is bow built. ppc64 fails everywhere and it looks like some issue in c10s, I don't think we can do anything but wait. The issue with tmate (and probably other packages) was order - tmate has to be build after msgpack, unfortunately, copr does not have dependency ordering afaik.

@pbrezina
Copy link
Member

I rebuilt packages in order and the only one still failing is libfaketime, I don't remember what we use it for though. That one simply exits with

+ FAKETIME_COMPILE_CFLAGS=BOGUS
+ '[' BOGUS == BOGUS ']'
+ echo 'SHOULD NEVER REACH HERE ... YOU HAVE AN UNTESTED VERSION+ARCH, see rpm spec for details ... ABORT'
+ exit 1
error: Bad exit status from /var/tmp/rpm-tmp.1rnZcM (%build)
    %patchN is deprecated (3 usages found), use %patch N (or %patch -P N)
    Bad exit status from /var/tmp/rpm-tmp.1rnZcM (%build)

@pbrezina
Copy link
Member

Btw, you can disable other distros for testing purpose to make pr ci faster. See: #91

@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented Apr 19, 2024

@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented Apr 19, 2024

ibfaketime, I don't remember what we use it for though

It's for unit tests:
https://github.com/SSSD/sssd/blob/7293eeea53458d1596262ee0f6593e08c38af7db/src/tests/test_CA/Makefile.am#L101

But if package is missing it's not a hardfail, just test will be skipped.

Btw, it's in https://kojihub.stream.centos.org/kojifiles/repos/c10s-build/latest/x86_64/pkglist list, not sure why it fails to install.

@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented Apr 19, 2024

It's also unclear where 'vpcd' - https://github.com/SSSD/sssd-ci-containers/blob/master/src/ansible/roles/packages/tasks/Fedora.yml#L170 - should be installed from.

UPD: part of 'virtualsmartcard'

@alexey-tikhonov
Copy link
Member Author

alexey-tikhonov commented Apr 19, 2024

- No package mock available.

UPD: I think its use was removed in SSSD/sssd@5def61f and not needed anymore

@alexey-tikhonov
Copy link
Member Author

No package fakeroot available
It's missing in https://kojihub.stream.centos.org/kojifiles/repos/c10s-build/latest/x86_64/pkglist

@andreboscatto andreboscatto merged commit 84b3556 into SSSD:master Apr 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants