Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for PMT data reconstruction #559

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Nov 14, 2024

Description

This pull request introduces the set of required changes to run the PMT data reconstruction. In particular it:

  • enables deconvolution on raw PMT waveforms using a SER that has been calibrated for each PMT.
  • allows for a channel-dependent noise filter (only gauss option at the moment, Wiener filter has to be tested and implemented).
  • corrects baseline oscillations on the deconvolved waveforms that are due to low-frequency noise on the raw waveforms.
  • configures the OpHitFinder parameters that are changed to run on data.
  • by default runs only on the subset of PMTs whose reconstruction has been validated. Further work will follow to have the rest of the PMTs validated.

This PR does also require to have a the new file digi_pmt_sbnd_v02_data.root added to sbnd_data under the OpDetSim folder.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

To be added

Link(s) to docdb describing changes (optional)

To be added

@asanchezcastillo asanchezcastillo self-assigned this Nov 14, 2024
@asanchezcastillo asanchezcastillo added pds Photon Detection System reco1/reco2 Reconstruction data features for data processing labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data features for data processing pds Photon Detection System reco1/reco2 Reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant