#10609 - fix decryption XML replacement for PHP 8.x

[yphoenix]

Fixes the issue uncovered with PHP 8.1 when merging a decrypted XML segment into its parent.

#562

[pitbulk]

Hi @yphoenix can you add to the PR the test case you described on the issue you shared?
I want to make sure to cover it.

Also I plan to review the issue recently described robrichards/xmlseclibs#257

Also it seems the test failed for PHP8.1 and PHP8.2

In one test case for example, disg namespace is defined in the EncryptedData element and in the other not

<saml:EncryptedID><xenc:EncryptedData xmlns:xenc="http://www.w3.org/2001/04/xmlenc#" Type="http://www.w3.org/2001/04/xmlenc#Element"><xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#aes128-cbc"/><dsig:KeyInfo xmlns:dsig="http://www.w3.org/2000/09/xmldsig#"><xenc:EncryptedKey><xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#rsa-1_5"/><xenc:CipherData><xenc:CipherValue>

<saml:EncryptedID><xenc:EncryptedData xmlns:xenc="http://www.w3.org/2001/04/xmlenc#" xmlns:dsig="http://www.w3.org/2000/09/xmldsig#" Type="http://www.w3.org/2001/04/xmlenc#Element"><xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#aes128-cbc"/><dsig:KeyInfo xmlns:dsig="http://www.w3.org/2000/09/xmldsig#"><xenc:EncryptedKey><xenc:EncryptionMethod Algorithm="http://www.w3.org/2001/04/xmlenc#rsa-1_5"/><xenc:CipherData><xenc:CipherValue>

[pitbulk]

It seems not related with your PR
https://github.com/SAML-Toolkits/php-saml/actions/runs/6268932337/job/17024640991

In an environment with OpenSSL 1.1.1f and PHP 8.1.18 test past

Your test from Aug 11 failed using 8.1.21 and based on the image used, OpenSSL 3.0.2-0ubuntu1.10

[pitbulk]

This test with openssl 3.X and PHP 8.0.30 past, but with 8.1.23 and 8.2.10 fails

macos with OpenSSL 1.1.1w and 8.0.30 worked but with PHP 8.1.23

I though it was openssl, but the issue seems related to PHP, checking the changelog there were a lot of recent changes on DOM class

I will need more time to identity what exact PHP version introduces the change that makes the test to fail.

[yphoenix]

I'll see if I can come up with a unit test for the decoding of the encrypted assertion. I may not be able to get to it immediately.

[yphoenix]

Looks like it will be fixed in the next release of PHP 8.x, in which case this PR will no-longer be needed.