Update requirements.txt #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing codecarbon
Raiduy
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Hi @Quartinocci, thanks for your update. Instead of adding codecarbon to the main requirements.txt, could you remove the codecarbon dependency in hello-world/RunnerConfig.py?
We already have a README.md for codecarbon and how to use it in Plugins, so I don't think having it in the example configs is worth it
Thanks,
Radu
| @@ -3,3 +3,4 @@ psutil | |||
| tabulate | |||
| dill | |||
| jsonpickle | |||
| codecarbon | |||
There was a problem hiding this comment.
As codecarbon isn't required for the healthy running of experiment-runner, adding it to the main requirements.txt is a bit overkill
|
Fixed in another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing codecarbon to requirements.txt