Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check queue settings to take inquiry #33782

Open
wants to merge 3 commits into
base: feat/single-contact-id
Choose a base branch
from

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Oct 25, 2024

Proposed changes (including videos or screenshots)

Whenever an agent tried to take a specific inquiry, we were checking the shouldTriggerVerificationApp method. That method, should only be used to avoid adding a visitor inquiry to the queue, not everytime, because of that we were having a few issues such as:

If the Livechat_Require_Contact_Verification setting was set to always, no conversation would ever be available to pick, even though the visitor might have been verified

This commit introduces the isAgentAvailableToTakeContactInquiry method, that should be used in those scenarios, also removes the check for Livechat_Block_Unknown_Contacts inside the bot call, since it does not do anything there, we now only check inside the isAgentAvailableToTakeContactInquiry method, along with a new setting to block unverified contacts (that was removed for some reason)

Issue(s)

Steps to test or reproduce

Further comments

SCI-117

Whenever an agent tried to take a specific inquiry, we were checking the shouldTriggerVerificationApp method.
That method, should only be used to avoid adding a visitor inquiry to the queue, not everytime, because of that we were having a few issues such as:

If the Livechat_Require_Contact_Verification setting was set to always, no conversation would ever be available to pick, even though the visitor might have been verified

This commit introduces the isAgentAvailableToTakeContactInquiry method, that should be used in those scenarios,
also removes the check for Livechat_Block_Unknown_Contacts inside the bot call, since it does not do anything there, we now only check
inside the isAgentAvailableToTakeContactInquiry method, along with a new setting to block unverified contacts (that was removed for some reason)
@Gustrb Gustrb requested a review from a team as a code owner October 25, 2024 12:50
Copy link
Contributor

dionisio-bot bot commented Oct 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: ed052e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 25, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33782/
on branch gh-pages at 2024-10-25 13:17 UTC

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (5e98135) to head (ed052e3).
Report is 329 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/single-contact-id   #33782       +/-   ##
===========================================================
+ Coverage                   58.43%   75.97%   +17.53%     
===========================================================
  Files                        2744      502     -2242     
  Lines                       66280    21667    -44613     
  Branches                    15001     5377     -9624     
===========================================================
- Hits                        38732    16461    -22271     
+ Misses                      24717     4561    -20156     
+ Partials                     2831      645     -2186     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.97% <ø> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant