-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check queue settings to take inquiry #33782
base: feat/single-contact-id
Are you sure you want to change the base?
fix: check queue settings to take inquiry #33782
Conversation
Whenever an agent tried to take a specific inquiry, we were checking the shouldTriggerVerificationApp method. That method, should only be used to avoid adding a visitor inquiry to the queue, not everytime, because of that we were having a few issues such as: If the Livechat_Require_Contact_Verification setting was set to always, no conversation would ever be available to pick, even though the visitor might have been verified This commit introduces the isAgentAvailableToTakeContactInquiry method, that should be used in those scenarios, also removes the check for Livechat_Block_Unknown_Contacts inside the bot call, since it does not do anything there, we now only check inside the isAgentAvailableToTakeContactInquiry method, along with a new setting to block unverified contacts (that was removed for some reason)
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33782 +/- ##
===========================================================
+ Coverage 58.43% 75.97% +17.53%
===========================================================
Files 2744 502 -2242
Lines 66280 21667 -44613
Branches 15001 5377 -9624
===========================================================
- Hits 38732 16461 -22271
+ Misses 24717 4561 -20156
+ Partials 2831 645 -2186
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Whenever an agent tried to take a specific inquiry, we were checking the shouldTriggerVerificationApp method. That method, should only be used to avoid adding a visitor inquiry to the queue, not everytime, because of that we were having a few issues such as:
If the Livechat_Require_Contact_Verification setting was set to always, no conversation would ever be available to pick, even though the visitor might have been verified
This commit introduces the isAgentAvailableToTakeContactInquiry method, that should be used in those scenarios, also removes the check for Livechat_Block_Unknown_Contacts inside the bot call, since it does not do anything there, we now only check inside the isAgentAvailableToTakeContactInquiry method, along with a new setting to block unverified contacts (that was removed for some reason)
Issue(s)
Steps to test or reproduce
Further comments
SCI-117