Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python dependencies "wrapt" and "inflection" in 22.04 ROS 2 #92

Open
matthias-mayr opened this issue Mar 1, 2024 · 7 comments
Open
Assignees

Comments

@matthias-mayr
Copy link
Member

In ROS 1 we installed wrapt and inflection as pip packages with requirements.txt.
In ROS 2 Humble on 22.04 we used the system packages so far. This should be a more stable choice, however, there is currently no procedure to install them.

The easiest way is to have again an install script and/or some instructions.
The nice way would be to make a PR for rosdep and make a PR for a new rule and put them in the package.xml

@matthias-mayr matthias-mayr changed the title Python dependencies "warpt" and "inflection" in 22.04 ROS 2 Python dependencies "wrapt" and "inflection" in 22.04 ROS 2 Mar 1, 2024
@matthias-mayr matthias-mayr added ROS 2 Issue affects ROS 2 good first issue labels Mar 1, 2024
@zanxueyan
Copy link

Currently, does skiros2 support ROS 2 Humble? I look at the code is still using ros1 library ah, where to download support ROS 2 Humble project? Ask for advice

@matthias-mayr
Copy link
Member Author

There is a ROS 2 branch that you can use and that works with humble. In the next weeks we are also working on a ROS 2 Jazzy version.

@bchen32
Copy link

bchen32 commented Sep 10, 2024

Seems like in the latest commit to the skiros2 master branch somebody added wrapt and inflection to the package.xml, but I don't think a rosdep rule has been made for them yet so installation (rosdep install --from-paths . --ignore-src --rosdistro=$ROS_DISTRO -y) is failing for me right now

@matthias-mayr
Copy link
Member Author

In ROS 1 or ROS 2? In humble as well as Jazzy, I can resolve python3-wrapt and python3-inflection

@bchen32
Copy link

bchen32 commented Sep 10, 2024

In ROS 1 or ROS 2? In humble as well as Jazzy, I can resolve python3-wrapt and python3-inflection

Might be a ROS1 issue then? I'm on noetic, ubuntu 20.04

@marcusklang
Copy link
Contributor

In ROS 1 or ROS 2? In humble as well as Jazzy, I can resolve python3-wrapt and python3-inflection

Might be a ROS1 issue then? I'm on noetic, ubuntu 20.04

I just tested it in a fresh docker container derived from the ros:noetic image.

This container with a clone of this repo resolved python3-wrapt and python3-inflection when running a similar command to yours:
rosdep install --from-paths src --ignore-src --rosdistro=${ROS_DISTRO} -y although this was meant to be run from the workspace root.

This container reports running Ubuntu 20.04.6 LTS inside.

@bchen32
Copy link

bchen32 commented Sep 11, 2024

Sorry, I realized I simply forgot to do rosdep update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants