Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrib varlinker noise #6

Open
wants to merge 21 commits into
base: contrib-mpc
Choose a base branch
from
Open

Contrib varlinker noise #6

wants to merge 21 commits into from

Conversation

kuanhanl
Copy link

Summary/Motivation:

Apply noise to measurements in MHE simulations.

Changes proposed in this PR:

  • Transfer some noise functions from idaes/caprese to this branch.
  • Modify var-linker interface to apply noise when transferring data.
  • Add tests for noise.py, new functions in var_linker.py, and MHE simulation with measurement noise.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@kuanhanl
dummy commit by creating a meaningless file
b3803d7
@kuanhanl
remove the file from dummy commit
b99e75e
@kuanhanl
add mhe_constructor and run_mhe
13d258c
@kuanhanl
modify descriptions
f0f0d21
@kuanhanl
rename get_error_cost to get_cost_from_error_variables
5dabe48
@kuanhanl
remove unused codes
b8bac1e
@kuanhanl
remove redundant check(same lb and ub if equality)
4fb5de9
@kuanhanl
move check out of constraint builder
f90bb23
@kuanhanl
accept nonzero bound model equalities
292bdff
@kuanhanl
add tests for mhe_constructor
34e832a
@kuanhanl
add test for run_mhe
2dcc59b
@kuanhanl
apply noise when using var_linker
0b2ae6b
@kuanhanl
add noise API
a4a1538
@kuanhanl
add the last blank line
d2fb24a
@kuanhanl
apply noise to mhe for cstr example
3ba3829
@kuanhanl
load the noised-measurements to measured variables
2318399
@kuanhanl
add missing input arguments
9069b60
@kuanhanl
tests for varLinker with noise
667ae73
@kuanhanl
add tests for noise.py
e7302a7
@kuanhanl
minor changes
5a60bc5
@kuanhanl
add tests for case with error
9307d2e
@kuanhanl
Copy link
Author

Please review the previous pull request Contrib mpc mhe before review this pull request.

@kuanhanl
Copy link
Author

@Robbybp In line 341-346 of noise test, it looks like you assume RuntimeError do not raise within 2 iterations, but is it possible that the error raises within 2 iterations?

blnicho pushed a commit that referenced this pull request Jan 30, 2023
@jialuw96
Merge pull request #6 from adowling2/patch-1
c06aa9d 
Update fim_doe.py
blnicho pushed a commit that referenced this pull request May 8, 2024
@smartin71
Merge pull request #6 from kaklise/parmest-redesign
2b542e9 
changed yhat to y_hat
Robbybp pushed a commit that referenced this pull request Jun 12, 2024
@adowling2
Merge pull request #6 from adowling2/pyomo-doe-fim-symmetry
6b6b85e 
Pyomo doe fim symmetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kuanhanl