require string, remove nodes params (#259)

RoamJS · May 19, 2024 · 40608d0 · 40608d0
1 parent f8acd94
commit 40608d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/query-builder.md b/docs/query-builder.md
@@ -210,7 +210,7 @@ For developers of other extensions who want to use the queries defined by users,
   - `uid` - `string` The reference of the primary node involved in the result.
   - `${string}-uid` - `string` If the users define selections that return intermediary nodes, the reference of those nodes will always end in `-uid` and will always be of type `string`.
   - `{string}` - `string | number | Date` All other fields returned in the result can be any of the primitive value types.
-- `isDiscourseNode` - `(uid?: string, nodes?: DiscourseNode[]) => boolean` Returns whether the input `uid` is a discourse node.
+- `isDiscourseNode` - `(uid: string) => boolean` Returns whether the input `uid` is a discourse node.
 
 ## Examples
 

diff --git a/src/utils/isDiscourseNode.ts b/src/utils/isDiscourseNode.ts
@@ -1,7 +1,8 @@
 import getDiscourseNodes from "./getDiscourseNodes";
 import findDiscourseNode from "./findDiscourseNode";
 
-const isDiscourseNode = (uid?: string, nodes = getDiscourseNodes()) => {
+const isDiscourseNode = (uid: string) => {
+  const nodes = getDiscourseNodes();
   const node = findDiscourseNode(uid, nodes);
   if (!node) return false;
   return node.backedBy !== "default";