New extension: Learn English in RR

[qcrao]

No description provided.

[github-actions]

Here’s your link to the diff:

Added qcrao/learn-english-in-RR 1bc02aa (PR-shorthand: qcrao+learn-english-in-RR+939)

[github-actions]

Here’s your link to the diff:

Added qcrao/learn-english-in-RR 1bc02aa (PR-shorthand: qcrao+learn-english-in-RR+939)

[github-actions]

Here’s your link to the diff:

Added qcrao/learn-english-in-RR e423fa1 (PR-shorthand: qcrao+learn-english-in-RR+939)

[qcrao]

@baibhavbista Hi, Can you help me review this new extension?🤩

[github-actions]

Here’s your link to the diff:

Changed qcrao/block-share-card 84a61bc → a2ec733 (PR-shorthand: qcrao+block-share-card+939)
Added qcrao/learn-english-in-RR e423fa1 (PR-shorthand: qcrao+learn-english-in-RR+939)

[github-actions]

Here’s your link to the diff:

Added qcrao/learn-english-in-RR a2ec733 (PR-shorthand: qcrao+learn-english-in-RR+939)

[panterarocks49]

Hi @qcrao, cool extension!

Here is my first pass at review

@anthropic-ai/sdk and lamejs appear to not be used, could you remove them from deps list?

You need to clean up the observer onunload https://github.com/qcrao/learn-english-in-RR/blob/a2ec7338d7ea3411719da46c41a17ad025856ee6/src/index.js#L61

You need to remove block context menu cmd onunload https://github.com/qcrao/learn-english-in-RR/blob/a2ec7338d7ea3411719da46c41a17ad025856ee6/src/utils/commands.js#L63

I used npx roamjs-scripts build --depot --analyze to analyze the bundle and it looks like font awesome is taking up a huge amount of space and you are only using it for a single icon, could you remove this?

I would suggest just using blueprint's icon https://blueprintjs.com/docs/versions/3/#icons for volume up, it looks about the same but matches RR's theme

[github-actions]

Here’s your link to the diff:

Added qcrao/learn-english-in-RR 4118e2b (PR-shorthand: qcrao+learn-english-in-RR+939)

[qcrao]

Hi @qcrao, cool extension!

Here is my first pass at review

@anthropic-ai/sdk and lamejs appear to not be used, could you remove them from deps list?

You need to clean up the observer onunload https://github.com/qcrao/learn-english-in-RR/blob/a2ec7338d7ea3411719da46c41a17ad025856ee6/src/index.js#L61

You need to remove block context menu cmd onunload https://github.com/qcrao/learn-english-in-RR/blob/a2ec7338d7ea3411719da46c41a17ad025856ee6/src/utils/commands.js#L63

I used npx roamjs-scripts build --depot --analyze to analyze the bundle and it looks like font awesome is taking up a huge amount of space and you are only using it for a single icon, could you remove this?

I would suggest just using blueprint's icon https://blueprintjs.com/docs/versions/3/#icons for volume up, it looks about the same but matches RR's theme

@panterarocks49 Thanks you very much for your review. I have addressed all the issues and updated the version.

[github-actions]

Here’s your link to the diff:

Added qcrao/learn-english-in-RR be79ca3 (PR-shorthand: qcrao+learn-english-in-RR+939)