Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use connections for embedded arrays #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Secretmapper
Copy link

Fixes #117

Use Relay Connections for arrays of Sub-Documents.

This is a breaking change as it casts every array of subdocuments into relay style connections/edges. I figured this is okay as the relay connections can do everything graphqllists can do, but not vice-versa.

I'm not really sure if it is possible to cherry-pick or allow the addition of a sentinel value on the schema to prevent this, but I wasn't able to find any (since we're passing the Schema and not just the type object, it doesn't seem to allow the addition of arbitrary properties).

Again, let me know if you think it's all right and I'll add tests for them.

@atalebagha
Copy link

any updates on this PR?

@tothandras
Copy link
Contributor

@atalebagha I'll try to finish it, thanks for reminding me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants