Fix for issue #58, issue #83 and Issue #87 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exception is thrown if data bag is not found. Chef does do good job of handling absence of data bag (or data bag item)
2. Changes to settings LWRP to allow value to be another nested hash (json) e.g. if you want to update HTTP Proxy Host for nexus repository you need to set property 'remoteProxySettings' to value '{"httpProxySettings" => {"proxyHostname" => "proxy.com", "proxyPort" => 81 }}'. Lo
gic with JsonPath and gsub doesn't seem to handle cases like this.
2. Updated documentation to enhanced settings functionality (to all value of element to be a Hash structure for nested elements)
|
Thanks for supporting Berkshelf 3. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #58 and also resolves #83 and also resolves #87
Fix I came up for issue #58 is pretty similar to one submitted before. If you think it is not the right way to fix it, you can discard commits e506877 and 8266239.