-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow artifact_file to handle snapshot and latest version correctly #125
Closed
Closed
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6edd097
wip
e8c33d6
snapshot and latest checksum check fixed
4272ff6
ruby syntax
139b743
ruby syntax
b7ec58e
loggin message in case of snapshot version
848d811
loggin message in case of snapshot version
796ea84
remove already patched file resource
6416ed1
latest version issue fixed
9c409bd
using negative index to get artifact version from coordinates
cc7ae5f
Merge pull request #124 from BarthV/123-fix
KAllan357 cae8147
wip
40731b3
snapshot and latest checksum check fixed
0b9fb2e
ruby syntax
bab8aba
ruby syntax
4868658
loggin message in case of snapshot version
884631b
loggin message in case of snapshot version
315da93
remove already patched file resource
aa4aa2a
latest version issue fixed
9291014
using negative index to get artifact version from coordinates
29f75e5
Merge branch 'file-handle-snapshot' of https://github.com/BarthV/arti…
51a6bbd
merge fix #124 for local tests
3a39ced
LWRP file : new resource attr + handling symlink
8fad345
comments & readme update
a656c42
Merge pull request #1 from BarthV/file-symlink
BarthV 924c91a
moved symlink attr presence test
d9eece7
def fix
14ae606
doc fix
1277b40
Merge pull request #2 from BarthV/file-symlink
BarthV 5bc48b4
dest_file from nexus reworked
7e5aeab
log info updated - FINAL version
c5e5457
fix issue - file is OK but snapshot is deleted
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should come up with a way to refactor this so that we don't have to do this splitting logic. I think adding a new
snapshot?
andlatest?
toChef::Artifact::Nexus
would do the trick - see https://github.com/RiotGames/artifact-cookbook/blob/master/libraries/chef_artifact_nexus.rb#L30-L31 for reference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll work on this and think about adding new snapshot/latest method directly at Nexus object level.