update CRAN comments

RinteRface · Sep 3, 2024 · 2b76dc5 · 2b76dc5
1 parent cb84206
commit 2b76dc5
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 10 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -32,7 +32,7 @@ Suggests:
     DT, 
     thematic (>= 0.1.2)
 Encoding: UTF-8
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.2
 VignetteBuilder: knitr
 Collate: 
     'feedbacks.R'

diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,7 @@
 
 ## Minor change
 - Update jquery-ui to 1.13.2. Thanks @biognosys-so.
+- Fix CRAN NOTES.
 
 # bs4Dash 2.3.3
 

diff --git a/R/tabs.R b/R/tabs.R
@@ -261,11 +261,11 @@ tabsetPanel <- function(..., id = NULL, selected = NULL,
 
 
 
-#' Insert a \link{tabPanel} in a \link{tabsetPanel}
+#' Insert a \link[shiny]{tabPanel} in a \link{tabsetPanel}
 #'
 #' @param inputId  \link{tabsetPanel} id.
-#' @param tab \link{tabPanel} to insert.
-#' @param target \link{tabPanel} after of before which the new tab will be inserted.
+#' @param tab \link[shiny]{tabPanel} to insert.
+#' @param target \link[shiny]{tabPanel} after of before which the new tab will be inserted.
 #' @param position Insert before or after: \code{c("before", "after")}.
 #' @param select Whether to select the newly inserted tab. FALSE by default.
 #' @param session Shiny session object.

diff --git a/cran-comments.md b/cran-comments.md
@@ -9,5 +9,13 @@
 There were no ERRORs or WARNINGs or NOTEs.
 
 ## Note
-This release will fixe the NOTES on https://cran.r-project.org/web/checks/check_results_bs4Dash.html.
-Update: re-submissiom fixing issue with `omicsTools` reverse dependency.
+Fix a 3 NOTES:
+
+> Version: 2.3.3
+Check: Rd cross-references
+Result: NOTE 
+  Found the following Rd file(s) with Rd \link{} targets missing package
+  anchors:
+    insertTab.Rd: tabPanel
+  Please provide package anchors for all Rd \link{} targets not in the
+  package itself and the base packages.
diff --git a/man/insertTab.Rd b/man/insertTab.Rd