Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for avatar decorations #260

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VelvetToroyashi
Copy link
Contributor

@MazeXP
Copy link
Contributor

MazeXP commented Dec 11, 2022

@VelvetToroyashi
Copy link
Contributor Author

Ah yes, the deserialization tests. Almost forgot. Thanks!

/// <returns>A result which may or may not have succeeded.</returns>
public static Result<Uri> GetUserAvatarDecorationUrl
(
IUser user,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPartialUser might be better to use to also support those instances.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's IUser to be consistent with the other methods (such as GetUserBannerUrl below)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think IPartialUser should be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that'd be better suited for its own PR to overhaul the entire CDN class. cc @Nihlus?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say so aswell with its own PR then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do that separately.

@Nihlus
Copy link
Member

Nihlus commented Apr 29, 2024

Any updates on this PR?

@Nihlus Nihlus added the waiting for author The PR is awaiting an update from the author label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author The PR is awaiting an update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants