[RAI-15505] Configurable default values #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcgr
changed the title
mmcgr
changed the title
mcmcgrath13
reviewed
Aug 25, 2023
src/code-util.jl
Outdated
| @@ -345,3 +345,8 @@ function get_logging_io() | |||
| ctx = IOContext(io, stream) | |||
| return io, ctx | |||
| end | |||
|
|
|||
| default_timeout() = parse(Int64, get(ENV, "TEST_REL_TEST_TIMEOUT", "300")) | |||
| default_allowed() = Symbol(get(ENV, "TEST_REL_ALLOWED", "warning")) | |||
There was a problem hiding this comment.
allowed is a little vague here - maybe SEVERITY_ALLOWED ?
mcmcgrath13
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
beautiful! one naming thought, but otherwise looks excellent
cc @nystrom this was the PR I was mentioning where you could set the default allow level to :none to get a sense of potential diagnostics changes impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configurable global default for test timeout and allow_unexpected. Update db and engine names to use a similar approach.
Engine naming now has two ways to be configured - changing the default base name (e.g. test_rel-1, test_rel-2, etc) or replacing the generator entirely (e.g. provision engine then generate a different name if there were problems).