Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TransactionsByTag test, and use UUID for the tag to prevent collisions. #108

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Re-enable TransactionsByTag test, and use UUID for the tag to prevent collisions. #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a791e35
Revert "Speculatively disable test blocking MQ as requested by Trevor…
rbvermaa Aug 15, 2024
ec4acfc
Use UUID4 string for tag to limit collisions with possibly concurrent…
rbvermaa Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions rai/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,26 +355,23 @@ func TestListTransactions(t *testing.T) {
}

// testing tag filters for transactions
// @FIXME: Temporarily disabled due to blocking MQ without oncallers available
// for RCA. See https://relationalai.slack.com/archives/C028U514FQV/p1723672487903109
// for details.
// func TestListTransactionsByTag(t *testing.T) {
// client := test.client
func TestListTransactionsByTag(t *testing.T) {
client := test.client

// query := "x, x^2, x^3, x^4 from x in {1; 2; 3; 4; 5}"
// tag := fmt.Sprintf("rai-sdk-go:%d", time.Now().Unix())
// txn, err := client.Execute(test.databaseName, test.engineName, query, nil, true, tag)
// assert.Nil(t, err)
query := "x, x^2, x^3, x^4 from x in {1; 2; 3; 4; 5}"
tag := fmt.Sprintf("rai-sdk-go:%s", uuid.New().String())
txn, err := client.Execute(test.databaseName, test.engineName, query, nil, true, tag)
assert.Nil(t, err)

// expectedProblems := []Problem{}
// assert.Equal(t, expectedProblems, txn.Problems)
expectedProblems := []Problem{}
assert.Equal(t, expectedProblems, txn.Problems)

// txns, err := client.ListTransactions(tag)
// assert.Nil(t, err)
txns, err := client.ListTransactions(tag)
assert.Nil(t, err)

// assert.Equal(t, 1, len(txns), "filter tag did not apply as expected")
assert.Equal(t, 1, len(txns), "filter tag did not apply as expected")

// }
}

func findRelation(relations []RelationV1, colName string) *RelationV1 {
for _, relation := range relations {
Expand Down
Loading