Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCCDOC-2557: Adding a Doc tile to OCP Lib #192

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

jseseCCS
Copy link
Collaborator

HCCDOC-2557: Adding a Doc tile to OCP Lib from OS Learning Resources page

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jseseCCS
Copy link
Collaborator Author

@Hyperkid123 hi, Martin! i hope you can review this for accuracy, etc. thanks!

@Hyperkid123
Copy link
Collaborator

/ok-to-test

@Hyperkid123
Copy link
Collaborator

Hyperkid123 commented Jun 12, 2024

Hi @jseseCCS there is no associated metadata file for the tile. It will not be "discovered" and seeded. The initial setup of a new tile is described here: https://github.com/RedHatInsights/quickstarts/blob/main/docs/quickstarts/README.md#create-a-working-branch-and-make-your-docs-updates

@jseseCCS
Copy link
Collaborator Author

i knew i'd forgotten something, @Hyperkid123! thanks. adding now.

@jseseCCS
Copy link
Collaborator Author

@Hyperkid123 here's an image grab of my folder structure with this yaml file. do I have to put it in its own folder and give it its own metadata file or can I keep it in the same folder (like you see in this image) and add two names to the metadata file?

Screenshot from 2024-06-12 10-28-06

@Hyperkid123
Copy link
Collaborator

@jseseCCS yes. Each tile needs its own folder, metadata file, and content file.

@jseseCCS
Copy link
Collaborator Author

@Hyperkid123 take another look? it seems like I made it worse but I can't imagine how!

Copy link
Collaborator

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change and I think this can be merged 🙂

apiVersion: console.openshift.io/v1
kind: QuickStarts
metadata:
name: openshift-ocp-library
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name as to be openshift-ocp-2

It needs to match the name from the metadata file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhhhhhhh ok! fixing

@jseseCCS
Copy link
Collaborator Author

@Hyperkid123 still getting all these errors. what am I doing wrong? and thank you so much for all your help!

@Hyperkid123
Copy link
Collaborator

@jseseCCS The filename did not match. The security errors can be ignored. I've pushed the filename change. I'll merge the PR once I get thumbs up from you 🙂 .

@jseseCCS
Copy link
Collaborator Author

@Hyperkid123 please go for it and thank you!!

@Hyperkid123
Copy link
Collaborator

/retest

@Hyperkid123 Hyperkid123 merged commit a859e77 into RedHatInsights:main Jun 18, 2024
3 of 4 checks passed
@jseseCCS
Copy link
Collaborator Author

tysm, @Hyperkid123!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants