-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCCDOC-2557: Adding a Doc tile to OCP Lib #192
Conversation
Can one of the admins verify this patch? |
@Hyperkid123 hi, Martin! i hope you can review this for accuracy, etc. thanks! |
/ok-to-test |
Hi @jseseCCS there is no associated metadata file for the tile. It will not be "discovered" and seeded. The initial setup of a new tile is described here: https://github.com/RedHatInsights/quickstarts/blob/main/docs/quickstarts/README.md#create-a-working-branch-and-make-your-docs-updates |
i knew i'd forgotten something, @Hyperkid123! thanks. adding now. |
@Hyperkid123 here's an image grab of my folder structure with this yaml file. do I have to put it in its own folder and give it its own metadata file or can I keep it in the same folder (like you see in this image) and add two names to the metadata file? |
@jseseCCS yes. Each tile needs its own folder, metadata file, and content file. |
@Hyperkid123 take another look? it seems like I made it worse but I can't imagine how! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change and I think this can be merged 🙂
apiVersion: console.openshift.io/v1 | ||
kind: QuickStarts | ||
metadata: | ||
name: openshift-ocp-library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name as to be openshift-ocp-2
It needs to match the name from the metadata file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhhhhhhhh ok! fixing
@Hyperkid123 still getting all these errors. what am I doing wrong? and thank you so much for all your help! |
@jseseCCS The filename did not match. The security errors can be ignored. I've pushed the filename change. I'll merge the PR once I get thumbs up from you 🙂 . |
@Hyperkid123 please go for it and thank you!! |
/retest |
tysm, @Hyperkid123! |
HCCDOC-2557: Adding a Doc tile to OCP Lib from OS Learning Resources page