Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newest goconst issue: remove duplicated string literal #227

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

tisnik
Copy link
Collaborator

@tisnik tisnik commented Aug 28, 2023

Description

Fix newest goconst issue: remove duplicated string literal

Type of change

  • Refactor (refactoring code, removing useless files)

Testing steps

To be checked on CI.

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (9a62a5b) 59.80% compared to head (1b25490) 59.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   59.80%   59.80%           
=======================================
  Files           7        7           
  Lines         908      908           
=======================================
  Hits          543      543           
  Misses        326      326           
  Partials       39       39           
Files Changed Coverage Δ
storage.go 65.34% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tisnik tisnik merged commit 48db264 into RedHatInsights:master Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants