Remove double exception print #4246
Conversation
Glutexo
added
the
client
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4246 +/- ##
==========================================
+ Coverage 76.94% 77.10% +0.16%
==========================================
Files 758 758
Lines 41361 41360 -1
Branches 8734 8734
==========================================
+ Hits 31826 31892 +66
+ Misses 8482 8409 -73
- Partials 1053 1059 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This pull request contains changes requested by Matyáš. First, I extracted the changes from #4191 that didn’t belong to that PR. Then, I only kept the requested changes, replacing an intermediary PR #4237. Both pull requests introduce changes to the now untested test connection mechanic and both deal with exception handling. Because of that, general unit tests for sub-method calls are included in both of them. After one PR will have been merged I will resolve the conflict in the other one. As for the caplog fixture, that is not supported on Python ≤2.7, I’m aware that the suggestion was to mark the tests as skipped. The change to logger asserts was however trivial. Moreover, I already used those in the sister pull request #4211. Such asserts are less semantic, but working. They need to be replaced after fixing the pipeline, but so do the skip marks. Opening the pull request for review. @m-horky |
Glutexo
force-pushed
the
double-exception-only
branch
from
b7596a8
to
42f4da9
Compare
In case of a connection error, an exception description was printed on the standard output twice: once by the outer test_connection method and once by the inner _(legacy_)test_urls method. The legacy version tries multiple URLs and prints the exception description on each failure. Thus, removed the outer print that only duplicates the last caught exception. Card IDs: * CCT-724 Signed-off-by: Štěpán Tomsa <[email protected]>
Glutexo
force-pushed
the
double-exception-only
branch
from
42f4da9
to
b9e76ea
Compare
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
In case of a connection error, an exception description was printed on the standard output twice: once by the outer test_connection method and once by the inner _(legacy_)test_urls method. The legacy version tries multiple URLs and prints the exception description on each failure. Thus, removed the outer print that only duplicates the last caught exception.
Card IDs: