Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK/CCT-296: Remove meson configuration for older versions of insights #176

Closed
wants to merge 0 commits into from

Conversation

grunwmar
Copy link

[reopened]
We change the build to meson, and agree to use the main branch for the latest release.

The meson configuration still has ancient parts for configure insights-client for older versions of RHEL (6,7), which at this point are not needed to be in that branch.

Done Criteria:

  • There is not unused code in meson build files (like cron configuration)

My jobs:

  • I iterated meson files and found unused parts
  • I removed unnecessary conditions from these
  • I removed unused data/cron directory from the project due to previous point, I also iterated makefiles and did similar changes as in meson files to prevent errors
  • i removed data/cron from configure.ac
  • i also edited /meson.build file and took out required: false attribute from dependency() for systemd

As I was mentally more or less limited (words from Diablo II "Not enough manna." quite fits) for some months I am now very unconfident and unsure, so every notes, points on this pull request, even smallest details, are more then welcome.

@ptoscano
Copy link
Contributor

/packit build

Copy link
Contributor

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! They generally LGTM.

Would you please amend the commit to mention that you are making systemd mandatory, and dropping the support for non-systemd configurations (such as the cron file); also, the task ID can be in its own like to avoid filling the first line of the commit message.

I suggest something on the lines of:

feat: drop support for non-systemd configuration

Make systemd mandatory, and drop support for non-systemd configurations
such as the cron file.

Card ID: CCT-296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants