-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package that displays a message for oudated browser #2872
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2872 +/- ##
==========================================
+ Coverage 63.59% 63.66% +0.07%
==========================================
Files 202 203 +1
Lines 4650 4651 +1
Branches 858 858
==========================================
+ Hits 2957 2961 +4
+ Misses 1683 1680 -3
Partials 10 10
|
/retest |
9edef66
to
a7cec55
Compare
/retest |
It appears Cypress is configured to use an ancient User-Agent insights-chrome/cypress.config.ts Lines 46 to 47 in d17fb3d
|
We should run the content and banner by UX do double check brand standards. I know from looking the banner doesn't follow PatternFly guidelines and would like to see if they have guidance for us. |
It might be. It's very likely the lib is looking at this. its worth a shot. If that says its chrome 51 its basically an ancient version. Current is 120 or something. |
f5303c2
to
a40fa24
Compare
Updated the userAgent. I still have a test failing locally, but it appeared to also be failing on |
/retest There is always one run failing |
See RHCLOUD-27572.
The
outdatedBrowser()
call does accept an argument that tells it what browser versions to consider outdated, but I wasn't sure how to even start approaching determining that. For instance, the Patternfly documentation says the supported version for all browser is "latest", which is... less than helpful.