add turnpike content guard #2726
Draft
+199
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I set this to draft while additional tests run, but wanted to get this up here for perusal while I'm out through Friday. |
loadtheaccumulator
force-pushed
the
pulp_cert_contentguard
branch
2 times, most recently
from
6726259
to
0bab10b
Compare
lzap
reviewed
Nov 1, 2024
| } | ||
|
|
||
| ccg, err := ps.CompositeGuardEnsure(ctx, orgID, *hcg.PulpHref, *rcg.PulpHref) | ||
| ccg, err := ps.CompositeGuardEnsure(ctx, orgID, *hcg.PulpHref, *contentGuardHref) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
I really want us to stop expanding feature flags, would you consider simply adding the new CG in the chain? The composed CG works as a simple "OR" chain. Do not add the turnpike CG if it is not configured.
There was a problem hiding this comment.
Absolutely, I was thinking that last week when we talked, but took the shortcut with the flag.
There was a problem hiding this comment.
Although, it does give a clear indication which one is working this early on.
loadtheaccumulator
force-pushed
the
pulp_cert_contentguard
branch
2 times, most recently
from
9dcd572
to
4ceea24
Compare
Signed-off-by: Jonathan Holloway <[email protected]>
loadtheaccumulator
force-pushed
the
pulp_cert_contentguard
branch
from
4ceea24
to
d5ca88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add turnpike content guard for ostree and associated feature flag
Add stage URL swap feature flag to support turnpike switch
FIXES: HMS-4783
Type of change
What is it?