-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Red Hat Konflux update edge-backend #2715
Conversation
Signed-off-by: red-hat-konflux <[email protected]>
Can one of the admins verify this patch? |
/ok-to-test |
@adarshdubey-star this fails to build the container due to install issue on this line Line 60 in 824dcbe
I've got no idea how this works :/ We'll need David to help out here :)
|
@ezr-ondrej It typically builds on a specific Jenkins registered with subman so it has access to the additional packages. Maybe that's tripping it up here. |
Jup, I belive that is it, David had chased solution for other services for this, I do not know where we ended up tho :) |
/ok-to-test |
/retest |
- name: bundle | ||
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf | ||
- name: kind | ||
value: task | ||
resolver: bundles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezr-ondrej can you please push into this branch a commit that changes these lines?
- name: bundle | |
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf | |
- name: kind | |
value: task | |
resolver: bundles | |
- name: url | |
value: https://github.com/brianwcook/build-definitions.git | |
- name: revision | |
value: pre-registration | |
- name: pathInRepo | |
value: task/buildah/0.2/buildah.yaml | |
- name: kind | |
value: task | |
resolver: git |
I would like to test if Brian's changes fix the subscription issue for you 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge the changes, they have to be reverted later...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, gotcha, trying out.
- name: name | ||
value: buildah | ||
- name: bundle | ||
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can drop the followup commit and swap the reference both here and in on-pull:
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf | |
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:ac898831120f2d461992227d494b6a67f07ed9ef7e3a3fc2de9a34d905b80f6a |
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization