Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Konflux update edge-backend #2715

Closed
wants to merge 2 commits into from

Conversation

red-hat-konflux[bot]
Copy link
Contributor

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Signed-off-by: red-hat-konflux <[email protected]>
@app-sre-bot
Copy link

Can one of the admins verify this patch?

@ezr-ondrej ezr-ondrej closed this Oct 22, 2024
@ezr-ondrej ezr-ondrej reopened this Oct 22, 2024
@ezr-ondrej
Copy link
Member

/ok-to-test

@ezr-ondrej
Copy link
Member

@adarshdubey-star this fails to build the container due to install issue on this line

RUN microdnf install -y coreutils-single glibc-minimal-langpack \

I've got no idea how this works :/ We'll need David to help out here :)

[2/2] STEP 17/21: RUN microdnf install -y coreutils-single glibc-minimal-langpack      isomd5sum file ostree && microdnf clean all

(microdnf:10528): librhsm-WARNING **: 17:14:43.823: Found 0 entitlement certificates

(microdnf:10528): librhsm-WARNING **: 17:14:43.826: Found 0 entitlement certificates
Downloading metadata...
Downloading metadata...
Downloading metadata...
error: No package matches 'isomd5sum'
subprocess exited with status 1
subprocess exited with status 1
Error: building at STEP "RUN microdnf install -y coreutils-single glibc-minimal-langpack      isomd5sum file ostree && microdnf clean all": exit status 1

@loadtheaccumulator
Copy link
Collaborator

@adarshdubey-star this fails to build the container due to install issue on this line

RUN microdnf install -y coreutils-single glibc-minimal-langpack \

I've got no idea how this works :/ We'll need David to help out here :)

@ezr-ondrej It typically builds on a specific Jenkins registered with subman so it has access to the additional packages. Maybe that's tripping it up here.

@ezr-ondrej
Copy link
Member

@ezr-ondrej It typically builds on a specific Jenkins registered with subman so it has access to the additional packages. Maybe that's tripping it up here.

Jup, I belive that is it, David had chased solution for other services for this, I do not know where we ended up tho :)

@mergify mergify bot added the waiting for review Need reviewers label Oct 23, 2024
@adarshdubey-star
Copy link
Contributor

/ok-to-test

@skateman
Copy link
Member

/retest

Comment on lines +241 to +245
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf
- name: kind
value: task
resolver: bundles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezr-ondrej can you please push into this branch a commit that changes these lines?

Suggested change
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf
- name: kind
value: task
resolver: bundles
- name: url
value: https://github.com/brianwcook/build-definitions.git
- name: revision
value: pre-registration
- name: pathInRepo
value: task/buildah/0.2/buildah.yaml
- name: kind
value: task
resolver: git

I would like to test if Brian's changes fix the subscription issue for you 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge the changes, they have to be reverted later...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, gotcha, trying out.

- name: name
value: buildah
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the followup commit and swap the reference both here and in on-pull:

Suggested change
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:67f0290a8ad9a147cd28bb06af182b3e4b2b3ef17070196d476d8e2ae4302ecf
value: quay.io/konflux-ci/tekton-catalog/task-buildah:0.2@sha256:ac898831120f2d461992227d494b6a67f07ed9ef7e3a3fc2de9a34d905b80f6a

@red-hat-konflux red-hat-konflux bot closed this Oct 25, 2024
@red-hat-konflux red-hat-konflux bot deleted the appstudio-edge-backend branch October 25, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Need reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants