fix old SA1006 lint errors #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Holloway <[email protected]>
loadtheaccumulator
force-pushed
the
fix_lint_issues
branch
from
72bb80a
to
b854f95
Compare
ezr-ondrej
reviewed
Aug 20, 2024
| @@ -66,7 +65,7 @@ func (t *ThirdPartyRepo) ValidateRequest() error { | |||
| return errors.New(RepoNameCantBeInvalidMessage) | |||
| } | |||
| if !ValidateRepoURL(t.URL) { | |||
| return fmt.Errorf(InvalidURL) | |||
| return errors.New(InvalidURL) | |||
There was a problem hiding this comment.
we could have the Error as a constant directly InvalidURLErr = ..... That way whoever consumes the package can use errors.Is() ... to tell which error was returned (if interested).
Not a big deal, we'd need to refactor all the errors here, which is probably not what we want to do.
There was a problem hiding this comment.
Would be a nice follow-up if you'd like :)
There was a problem hiding this comment.
Definitely. Constants are used elsewhere, so we can always add error refactor to the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing simple SA1006 lint issues with formatted print statements and no formatting
FIXES:
Type of change
What is it?