-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CI for tang operator #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, do not use operator-sdk_linux_amd64 as the command for operator-sdk.
If installation guide is checked, here:
https://sdk.operatorframework.io/docs/installation/
The binary is moved to the path in this step:
3. Install the release binary in your PATH
chmod +x operator-sdk_${OS}_${ARCH} && sudo mv operator-sdk_${OS}_${ARCH} /usr/local/bin/operator-sdk
So, operator-sdk
is the correct name. No need to change it
41feceb
to
ebd44d9
Compare
3f576a2
to
e86dc0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, if possible, include a Resolves: #5
in commit, so that it closes the issue regarding Github CI action
d44abb7
to
5df762e
Compare
df85d88
to
0e5d0d5
Compare
|
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
|
|
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
|
|
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
|
Tang operator test will run on CI with using minikube. Prepare .yaml file for specifying packit run and preparing .fmf plan for run test via tmt. Prepared setup for install and setup minukube. Also polished tang operator test to be more structured. Resolves: #5
No description provided.