Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CI for tang operator #10

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Prepare CI for tang operator #10

merged 1 commit into from
Oct 16, 2023

Conversation

Koncpa
Copy link
Contributor

@Koncpa Koncpa commented Oct 9, 2023

No description provided.

Copy link
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not use operator-sdk_linux_amd64 as the command for operator-sdk.

If installation guide is checked, here:
https://sdk.operatorframework.io/docs/installation/

The binary is moved to the path in this step:

3. Install the release binary in your PATH
chmod +x operator-sdk_${OS}_${ARCH} && sudo mv operator-sdk_${OS}_${ARCH} /usr/local/bin/operator-sdk

So, operator-sdk is the correct name. No need to change it

@Koncpa Koncpa force-pushed the pk_CI branch 3 times, most recently from 41feceb to ebd44d9 Compare October 10, 2023 08:30
@Koncpa Koncpa marked this pull request as ready for review October 10, 2023 08:31
@Koncpa Koncpa changed the title DRAFT: Prepare CI for tang operator Prepare CI for tang operator Oct 10, 2023
Setup/setup_local_cluster/runtest.sh Outdated Show resolved Hide resolved
@Koncpa Koncpa force-pushed the pk_CI branch 2 times, most recently from 3f576a2 to e86dc0e Compare October 10, 2023 11:14
Copy link
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, if possible, include a Resolves: #5 in commit, so that it closes the issue regarding Github CI action

@Koncpa Koncpa force-pushed the pk_CI branch 3 times, most recently from d44abb7 to 5df762e Compare October 12, 2023 12:15
@Koncpa Koncpa force-pushed the pk_CI branch 4 times, most recently from df85d88 to 0e5d0d5 Compare October 16, 2023 08:27
@github-actions
Copy link

yamllint Failed

Show Output
::group::./.packit.yaml
::warning file=./.packit.yaml,line=1,col=1::1:1 [document-start] missing document start "---"
::error file=./.packit.yaml,line=2,col=1::2:1 [indentation] wrong indentation: expected at least 1
::error file=./.packit.yaml,line=13,col=1::13:1 [empty-lines] too many blank lines (1 > 0)
::endgroup::

Workflow: Yamllint, Action: __karancode_yamllint-github-action, Lint: ./

@packit-as-a-service
Copy link

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team.

@github-actions
Copy link

yamllint Failed

Show Output
::group::./.packit.yaml
::error file=./.packit.yaml,line=2,col=2::2:2 [indentation] wrong indentation: expected 0 but found 1
::error file=./.packit.yaml,line=3,col=1::3:1 syntax error: expected '<document start>', but found '<block sequence start>' (syntax)
::endgroup::

Workflow: Yamllint, Action: __karancode_yamllint-github-action, Lint: ./

@github-actions
Copy link

yamllint Failed

Show Output
::group::./.packit.yaml
::error file=./.packit.yaml,line=3,col=1::3:1 [indentation] wrong indentation: expected at least 1
::error file=./.packit.yaml,line=13,col=37::13:37 [new-line-at-end-of-file] no new line character at the end of file
::endgroup::

Workflow: Yamllint, Action: __karancode_yamllint-github-action, Lint: ./

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config. AttributeError("'list' object has no attribute 'setdefault'")

For more info, please check out the documentation or contact the Packit team.

@github-actions
Copy link

yamllint Failed

Show Output
::group::./.packit.yaml
::error file=./.packit.yaml,line=12,col=37::12:37 [new-line-at-end-of-file] no new line character at the end of file
::endgroup::

Workflow: Yamllint, Action: __karancode_yamllint-github-action, Lint: ./

@github-actions
Copy link

yamllint Failed

Show Output
::group::./.packit.yaml
::error file=./.packit.yaml,line=3,col=1::3:1 [indentation] wrong indentation: expected at least 1
::endgroup::

Workflow: Yamllint, Action: __karancode_yamllint-github-action, Lint: ./

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config. AttributeError("'list' object has no attribute 'setdefault'")

For more info, please check out the documentation or contact the Packit team.

@github-actions
Copy link

yamllint Failed

Show Output
::group::./.packit.yaml
::error file=./.packit.yaml,line=3,col=3::3:3 [indentation] wrong indentation: expected at least 3
::endgroup::

Workflow: Yamllint, Action: __karancode_yamllint-github-action, Lint: ./

Tang operator test will run on CI with using minikube.
Prepare .yaml file for specifying packit run and preparing
.fmf plan for run test via tmt.
Prepared setup for install and setup minukube.
Also polished tang operator test to be more structured.

Resolves: #5
@Koncpa Koncpa merged commit 2ccb544 into main Oct 16, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants