Do not add webhook server certificate to system CA trust store #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the CA certificate to 'trusted_server_ca' configuration should be sufficient. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Instead of using an old version of the agent, use the current code, but replacing the API version with an older supported version. This will reduce the chaces of compilation issues due to updated rust compiler or changes in the availability of dependencies. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
This change is to cover a corner case when the python components API version is bumped before the agent API version is bumped. In such a case, the latest old supported API version for the verifier would be the current agent API version. Then it is necessary to use the second to last to cause a difference in the API version. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
|
No point waiting, current keylime is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the CA certificate to 'trusted_server_ca' configuration should be sufficient.