Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set keylime_port_t label for random ports use in tests #437

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Koncpa
Copy link
Collaborator

@Koncpa Koncpa commented Aug 10, 2023

No description provided.

@Koncpa Koncpa self-assigned this Aug 10, 2023
@Koncpa Koncpa requested a review from kkaarreell August 10, 2023 14:38
@kkaarreell
Copy link
Collaborator

@Koncpa How to approach this for the main branch? We do not want to loose it but I assume it won't work on various Fedoras, right? Maybe we could do the change conditionally inside the test. WDYT?

@Koncpa
Copy link
Collaborator Author

Koncpa commented Aug 10, 2023

Sure, it is possible do it conditionally. It will be work just for RHEL-9.3.0, where are keylime ports labeled.

@Koncpa
Copy link
Collaborator Author

Koncpa commented Aug 10, 2023

But do we want to add if its RHEL conditions into test?

@kkaarreell
Copy link
Collaborator

But do we want to add if its RHEL conditions into test?

My concern is that we will forgot about it and it will be overwritten with the next rebase. And I do not expect you to backport those policy changes in older Fedoras. From this perspective I would rather have it in main, even though there would be if in the code. Btw, instead of rlIsRHEL I would rather exclude current (and in the future old) Fedoras. At least in the future when you get the change to Rawhide.

@Koncpa Koncpa changed the base branch from rhel-9-main to main August 11, 2023 08:15
@Koncpa Koncpa force-pushed the pk_label_keylime_ports branch 3 times, most recently from b9819d6 to a5b4073 Compare August 11, 2023 09:06
Apply condtionally for specific version of rhel and fedoras.
@Koncpa Koncpa merged commit 8a4d0da into main Aug 14, 2023
5 checks passed
@Koncpa Koncpa deleted the pk_label_keylime_ports branch August 30, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants