Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev feature flag for GET /extension-requests/self API #2152

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

samarpan1738
Copy link
Contributor

@samarpan1738 samarpan1738 commented Sep 12, 2024

Date: 13 Sep 2024

Developer Name: Samarpan Harit


Issue Ticket Number

Closes #2138

Description

  1. Keep the dev=true flow (has some changes related to multiple extension requests) and remove the dev=false flow
  2. Merge the multiple extension request tests with extension request tests

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Without `dev` feature flag

Screenshot from 2024-09-20 02-16-41

With `dev` feature flag

Screenshot from 2024-09-20 02-20-09

Test Coverage

NA

Additional Notes

@vinit717
Copy link
Member

Can you add a screenshot for changes with dev and without dev

@samarpan1738 samarpan1738 force-pushed the 2138-remove-dev-ff-get-extension-requests-self branch from 0018088 to 27df481 Compare September 20, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dev feature flag from GET /extension-requests/self API
3 participants