-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dev feature flag for GET /requests API #2151
Remove dev feature flag for GET /requests API #2151
Conversation
f792b07
to
4833d64
Compare
4833d64
to
1f22fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please verify on local also
a6fb05a
to
a6ae3f9
Compare
I have tested on local with and without |
8ec4a92
to
4d700da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as this has been reviewed by a couple of folks already and this looks fine to me
4d700da
to
3c07ca8
Compare
Date: 13 Sep 2024
Developer Name: Samarpan Harit
Issue Ticket Number
Closes #2139
Description
dev
query param from the next page link being set in the responsedev
query param optional in the request validatorDocumentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Get requests with `dev` FF
Get requests without `dev` FF
Test Coverage
NA
Additional Notes