Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev feature flag for GET /requests API #2151

Conversation

samarpan1738
Copy link
Contributor

@samarpan1738 samarpan1738 commented Sep 12, 2024

Date: 13 Sep 2024

Developer Name: Samarpan Harit


Issue Ticket Number

Closes #2139

Description

  1. Remove dev query param from the next page link being set in the response
  2. Make the dev query param optional in the request validator
  3. Update integration tests

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Get requests with `dev` FF

Screenshot from 2024-09-21 01-47-07

Get requests without `dev` FF

Screenshot from 2024-09-21 01-47-28

Test Coverage

NA

Additional Notes

Copy link
Contributor

@fakhruddinkw fakhruddinkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please verify on local also

@samarpan1738 samarpan1738 force-pushed the 2139-remove-dev-ff-get-requests branch 2 times, most recently from a6fb05a to a6ae3f9 Compare September 18, 2024 19:35
@samarpan1738
Copy link
Contributor Author

samarpan1738 commented Sep 18, 2024

LGTM, but please verify on local also

I have tested on local with and without dev feature flag. Working as expected
@fakhruddinkw

Copy link
Contributor

@shubhdevelop shubhdevelop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this has been reviewed by a couple of folks already and this looks fine to me

@iamitprakash iamitprakash merged commit edadf41 into Real-Dev-Squad:develop Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dev feature flag from GET /requests API
5 participants