Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev feature flag for POST /extension-requests API #2150

Conversation

samarpan1738
Copy link
Contributor

@samarpan1738 samarpan1738 commented Sep 12, 2024

Date: 13 Sep 2024

Developer Name: Samarpan Harit


Issue Ticket Number

Closes #2137

Description

  1. Keep the dev=true flow (allows to create multiple extension requests) and remove the dev=false flow
  2. Merge the multiple extension requests tests with extension requests test

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Create first extension request

Screenshot from 2024-09-20 02-02-23

Create extension request when existing exists with PENDING status

Screenshot from 2024-09-20 02-01-35

Create extension request when existing exists with APPROVED status

Screenshot from 2024-09-20 02-07-02

Test Coverage

NA

Additional Notes

@samarpan1738 samarpan1738 force-pushed the 2137-remove-dev-ff-post-extension-requests branch from 5a91031 to 0bbecbe Compare September 20, 2024 20:06
@samarpan1738 samarpan1738 force-pushed the 2137-remove-dev-ff-post-extension-requests branch from 0bbecbe to bdce140 Compare September 21, 2024 19:36
@iamitprakash iamitprakash merged commit e789945 into Real-Dev-Squad:develop Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dev feature flag from POST /extension-requests API
5 participants