Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev feature flag for POST /discord-actions/nicknames/sync API #2148

Conversation

samarpan1738
Copy link
Contributor

@samarpan1738 samarpan1738 commented Sep 12, 2024

Date: 13 Sep 2024

Developer Name: Samarpan Harit


Issue Ticket Number

Closes #2128

Description

  1. Remove the 404 error when dev=false
  2. Remove dev FF from integration tests for this API

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

NA

Test Coverage

NA

Additional Notes

Copy link
Contributor

@fakhruddinkw fakhruddinkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samarpan1738 samarpan1738 force-pushed the 2128-post-discord-actions-nicknames-sync branch from c458be1 to c6703da Compare September 18, 2024 18:56
@samarpan1738 samarpan1738 force-pushed the 2128-post-discord-actions-nicknames-sync branch from c6703da to a4d9bfe Compare September 20, 2024 20:06
@samarpan1738 samarpan1738 force-pushed the 2128-post-discord-actions-nicknames-sync branch from a4d9bfe to 702a8a1 Compare September 21, 2024 19:36
@iamitprakash iamitprakash merged commit 9af8127 into Real-Dev-Squad:develop Sep 21, 2024
3 checks passed
@samarpan1738 samarpan1738 changed the title Remove dev feature flag for /discord-actions/nicknames/sync API Remove dev feature flag for POST /discord-actions/nicknames/sync API Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dev feature flag from POST /discord-actions/nicknames/sync API
4 participants