Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect email for subscription #2124

Merged
merged 28 commits into from
Oct 16, 2024
Merged

Conversation

tejaskh3
Copy link
Contributor

@tejaskh3 tejaskh3 commented Sep 3, 2024

Date: Sept 3, 2024

Developer Name: Tejas

Design doc

DOC

Issue Ticket Number

Please don't close this issue.
#2123

Description

This PR includes two APIs
In this PR we have added APIs to collect user email and phone number to make them subscribe to RDS notifications, and even unsubscribe as well.
and to send email to a user.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Click to view Screenshots

Screenshot 1
image
image
image

Screenshot 3

Test Coverage

Click to view Test Coverage
  • Router
    Router Test Coverage

  • Validator
    Validator Test Coverage

  • Controller
    Controller Test Coverage

Additional Notes

Here is the API contract for the feature.
Real-Dev-Squad/website-api-contracts#189

@tejaskh3 tejaskh3 added feature task Feature that has to be built backend labels Sep 3, 2024
@tejaskh3 tejaskh3 self-assigned this Sep 3, 2024
@tejaskh3 tejaskh3 marked this pull request as draft September 3, 2024 16:31
routes/subscription.ts Fixed Show fixed Hide fixed
routes/subscription.ts Fixed Show fixed Hide fixed
routes/subscription.ts Fixed Show fixed Hide fixed
routes/subscription.ts Fixed Show fixed Hide fixed
routes/subscription.js Fixed Show resolved Hide resolved
routes/subscription.js Fixed Show resolved Hide resolved
routes/subscription.js Fixed Show resolved Hide resolved
@tejaskh3 tejaskh3 marked this pull request as ready for review September 8, 2024 17:18
controllers/subscription.ts Show resolved Hide resolved
routes/subscription.js Outdated Show resolved Hide resolved
controllers/subscription.ts Outdated Show resolved Hide resolved
routes/subscription.ts Fixed Show fixed Hide fixed
routes/subscription.ts Fixed Show fixed Hide fixed
routes/subscription.ts Fixed Show fixed Hide fixed
@prakashchoudhary07
Copy link
Contributor

Please attacht the design doc for it?

@tejaskh3
Copy link
Contributor Author

Please attacht the design doc for it?

Attached sir. please check

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is not under FF

config/custom-environment-variables.js Outdated Show resolved Hide resolved
controllers/subscription.ts Outdated Show resolved Hide resolved
config/default.js Outdated Show resolved Hide resolved
config/default.js Outdated Show resolved Hide resolved
config/default.js Outdated Show resolved Hide resolved
config/development.js Outdated Show resolved Hide resolved
controllers/subscription.ts Outdated Show resolved Hide resolved
controllers/subscription.ts Outdated Show resolved Hide resolved
controllers/subscription.ts Outdated Show resolved Hide resolved
routes/subscription.ts Outdated Show resolved Hide resolved
@tejaskh3
Copy link
Contributor Author

why this is not under FF

Done sir.

@tejaskh3 tejaskh3 requested review from iamitprakash, yesyash and vinit717 and removed request for sahsisunny September 12, 2024 20:52
controllers/subscription.ts Outdated Show resolved Hide resolved
routes/index.ts Outdated Show resolved Hide resolved
lakshayman
lakshayman previously approved these changes Oct 13, 2024
Copy link
Contributor

@lakshayman lakshayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

middlewares/devFlag.ts Show resolved Hide resolved
middlewares/validators/subscription.ts Show resolved Hide resolved
test/integration/subscription.test.js Show resolved Hide resolved
middlewares/validators/subscription.ts Outdated Show resolved Hide resolved
config/custom-environment-variables.js Outdated Show resolved Hide resolved
routes/subscription.ts Outdated Show resolved Hide resolved
config/custom-environment-variables.js Outdated Show resolved Hide resolved
@iamitprakash iamitprakash self-requested a review October 14, 2024 19:25
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve all comments from Prakash sir

@iamitprakash iamitprakash merged commit 9a5e799 into develop Oct 16, 2024
3 checks passed
@iamitprakash iamitprakash deleted the subscription-feature branch October 16, 2024 05:53
@Achintya-Chatterjee Achintya-Chatterjee mentioned this pull request Oct 16, 2024
10 tasks
@tejaskh3 tejaskh3 restored the subscription-feature branch October 21, 2024 20:19
@tejaskh3
Copy link
Contributor Author

tejaskh3 commented Nov 9, 2024

successfully merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature task Feature that has to be built
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants