Skip to content

Commit

Permalink
chore: remove dev FF from GET /logs integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
samarpan1738 committed Sep 20, 2024
1 parent 1caeb6d commit ec59a65
Showing 1 changed file with 9 additions and 25 deletions.
34 changes: 9 additions & 25 deletions test/integration/logs.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe("/logs", function () {
it("should return 401 if user is not logged in", function (done) {
chai
.request(app)
.get("/logs?dev=true")
.get("/logs")
.end(function (err, res) {
if (err) {
return done(err);
Expand All @@ -97,26 +97,10 @@ describe("/logs", function () {
});
});

it("should return 400, if user has access and dev flag is not", function (done) {
chai
.request(app)
.get("/logs")
.set("cookie", `${cookieName}=${superUserToken}`)
.end(function (err, res) {
if (err) {
return done(err);
}
expect(res).to.have.status(400);
expect(res.body.error).to.equal("Bad Request");
expect(res.body.message).to.equal(`Please use feature flag to make this request!`);
return done();
});
});

it("should return all Logs", function (done) {
chai
.request(app)
.get("/logs?dev=true")
.get("/logs")
.set("cookie", `${cookieName}=${superUserToken}`)
.end(function (err, res) {
if (err) {
Expand All @@ -132,7 +116,7 @@ describe("/logs", function () {
it("should return all formatted Logs", function (done) {
chai
.request(app)
.get("/logs?dev=true&format=feed")
.get("/logs?format=feed")
.set("cookie", `${cookieName}=${superUserToken}`)
.end(function (err, res) {
if (err) {
Expand All @@ -159,7 +143,7 @@ describe("/logs", function () {
it("should return logs of type = extensionRequests", function (done) {
chai
.request(app)
.get("/logs?type=extensionRequests&dev=true")
.get("/logs?type=extensionRequests")
.set("cookie", `${cookieName}=${superUserToken}`)
.end((err, res) => {
if (err) {
Expand All @@ -174,7 +158,7 @@ describe("/logs", function () {
it("if no logs are present, should return valid response", function (done) {
chai
.request(app)
.get("/logs?type=REQUEST_CREATED1&dev=true")
.get("/logs?type=REQUEST_CREATED1")
.set("cookie", `${cookieName}=${superUserToken}`)
.end((err, res) => {
if (err) {
Expand All @@ -189,31 +173,31 @@ describe("/logs", function () {
it("should return data if page param is passed in the quey", function (done) {
chai
.request(app)
.get("/logs?page=1&dev=true&size=3")
.get("/logs?page=1&size=3")
.set("cookie", `${cookieName}=${superUserToken}`)
.end(function (err, res) {
if (err) {
return done(err);
}
expect(res.body.message).to.equal("All Logs fetched successfully");
expect(res.body.data).to.lengthOf(3);
expect(res.body.page).to.equal("/logs?page=2&dev=true");
expect(res.body.page).to.equal("/logs?page=2");
return done();
});
});

it("should return valid paginated link", function (done) {
chai
.request(app)
.get("/logs?dev=true&size=3")
.get("/logs?size=3")
.set("cookie", `${cookieName}=${superUserToken}`)
.end(function (err, res) {
if (err) {
return done(err);
}
expect(res.body.message).to.equal("All Logs fetched successfully");
expect(res.body.data).to.lengthOf(3);
expect(res.body.next).to.contain("/logs?dev=true&size=3&next=");
expect(res.body.next).to.contain("/logs?size=3&next=");
return done();
});
});
Expand Down

0 comments on commit ec59a65

Please sign in to comment.