Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only show hover feedback on clickable patch list items #236

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Apr 27, 2024

  • right now, all patches look clickable, and no patches can be tabbed to.
  • with this, we make expandable patches buttons (can be tabbed to), and only apply the hover animations to those. this makes it more clear when a patch can be expanded.
  • we also uplevel the animation wrapper div because it was causing the widths to be odd, probably also improving perf.

@oSumAtrIX oSumAtrIX changed the title fix: more accessible patches list fix: Only show hover feedback on clickable patch list items Apr 27, 2024
@oSumAtrIX
Copy link
Member

Something about this feels odd. Everything has some form of feedback and you feel under control, but when hovering over the list items, it feels empty:

msedge_zQ87DCxTyL.mp4

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Apr 27, 2024

Discord for example gives similar visual clues by dimming the background even though theres no interactivity with the item itself but just some action buttons:

Vesktop_rdzQcMdnhZ.mp4

@Ushie
Copy link
Member

Ushie commented Apr 27, 2024

In the case of discord, there is a form of interactivity which is the right click/context menu, but I agree that it feels empty

@oSumAtrIX
Copy link
Member

I'd argue we have interactivity with the package chip, but I can see the UX issue with showing visual cues for interaction when the item is not really interactable, but yes, it feels empty.

@KTibow
Copy link
Contributor Author

KTibow commented Apr 27, 2024

I'd argue that while removing hover effects makes it feel less interesting, it emphasizes that it's less of something to put your mouse over and more a static list. This increases semantic alignment - static elements are, well, static, and expandable items are easily noticed.

re: discord hover: you can right click on the hovered message, so the hover makes sense there
re: package chip: the only time a hover effect for it should show up is when you're hovering on the clickable part. the whole card isn't the clickable part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants