Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): init docs #157

Draft
wants to merge 29 commits into
base: dev
Choose a base branch
from
Draft

feat(docs): init docs #157

wants to merge 29 commits into from

Conversation

Ushie
Copy link
Member

@Ushie Ushie commented Aug 7, 2023

No description provided.

@Ushie Ushie mentioned this pull request Aug 7, 2023
@Ushie Ushie marked this pull request as draft August 7, 2023 02:01
@revanced-bot
Copy link

Deployed at https://ea6fcf2e.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://30ee5bd9.revanced.pages.dev.

@Ushie Ushie changed the base branch from main to dev August 7, 2023 02:50
@revanced-bot
Copy link

Deployed at https://fdf03114.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://aa48f574.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://97ff6f30.revanced.pages.dev.

@revanced-bot
Copy link

Deployed at https://06473984.revanced.pages.dev.

@kazimmt
Copy link
Contributor

kazimmt commented Aug 8, 2023

Is it possible to add Image reference also for better understanding?

Refer to: This

@revanced-bot
Copy link

Deployed at https://head.revanced.pages.dev.

Copy link
Member Author

@Ushie Ushie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@Ushie
Copy link
Member Author

Ushie commented Aug 8, 2023

bruh the deployment link is for donation branch

@xafn
Copy link
Contributor

xafn commented Aug 8, 2023

💀

@kazimmt
Copy link
Contributor

kazimmt commented Aug 8, 2023

Review from current preview
If i click on the right side i.e. installation step
Top Menu goes away

edit: clicking any header makes the top menu disappear.
menu

@Ushie
Copy link
Member Author

Ushie commented Aug 8, 2023

I know what causes that, I'll fix that later tonight

@xafn
Copy link
Contributor

xafn commented Aug 8, 2023

bruh the deployment link is for donation branch

hard refresh page ctrl shift r, it was just cache

@xafn xafn mentioned this pull request Aug 9, 2023
@revanced-bot
Copy link

Deployed at https://d152fd7d.revanced.pages.dev.

Base automatically changed from dev to main August 9, 2023 20:24
@Ushie Ushie changed the base branch from main to dev August 9, 2023 20:31
@Ushie
Copy link
Member Author

Ushie commented Aug 10, 2023

FAT

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 10, 2023

Before this reaches production or even dev, a solution should be figured out regarding the issue of copying all the MD files. I suggest the following:

  1. Every repo with docs integrates Docusaurus. This feature change will transform all the MD files to "Docusaurus formatted" MD files.
  2. In junction with feat: add site configuration #137, the website offers a configuration that allows the following:
    • Specify a repository to get documentation from (in our case, the docs repo that contains submodules of all other reports)
    • Provide a mapping between the docs of the separate repos and categories that are exclusive to the website

This will allow:

  1. All the repositories to host docs standalone and independent of the website
  2. Deduplicate the docs
  3. Allow automatisation of updating the docs (at build time over triggering a CI specifically for docs)
  4. Remain agnostic apart from the configuration file (as specified in feat: add site configuration #137), which would be an env-specific configuration anyways

To proceed with this proposal, all the repos must first migrate to Docusaurus. For that, an issue may be opened, and a template repository could be provided that all the reports can add as a submodule to avoid code duplication and easily updating the docs by updating the submodule.

@xafn
Copy link
Contributor

xafn commented Aug 10, 2023

  1. Every repo with docs integrates Docusaurus. This feature change will transform all the MD files to "Docusaurus formatted" MD files.

What changes would be needed to the .md files? Or are you referring to how Docusaurus needs a _category.json file , in which case can also be generated through CI.

{
    "label": "ReVanced Development",
    "position": 1,
    "link": {
        "type": "generated-index"
    }
}

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Aug 10, 2023

What changes would be needed to the .md files?

The MD files in this PR have been changed to a specific format that is suitable for Docusaurus:

  1. The "Whats next" section is removed
  2. A Docusaurus header is added

are you referring to how Docusaurus needs a _category.json file , in which case can also be generated through CI.

The category files should not be generated by CI. The reason for this is, that both the documentation as well as the categories (part of the documentation) are environment-specific configurations. As #137 specified, this project should offer a configuration that allows ending agnostics at an environment-specific level. This means, the project itself remains agnostic, including CI, but the "ReVanced" configuration, that would be deployed, would be configured so that the site consumes our documentation and uses our set of category JSON files. Another deployment environment then can use its own site configuration as a product of the site being agnostic.

@oSumAtrIX oSumAtrIX linked an issue Jan 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

feat: FAQ/troubleshooting page
5 participants