Skip to content

Commit

Permalink
fix(YouTube - SponsorBlock): Correctly show minute timestamp when cre…
Browse files Browse the repository at this point in the history 
…ating a new segment
  • Loading branch information
@LisoUseInAIKyrios
LisoUseInAIKyrios committed Jul 26, 2024
1 parent 549731f commit d74c366
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/resources/addresources/values/strings.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ This is because Crowdin requires temporarily flattening this file and removing t
<string name="revanced_sb_new_segment_title">New SponsorBlock segment</string>
<!-- Do not rearrange the (hour):(minute):second) time format operators here.
YT shows the same seekbar time format for all languages, and this string is confirming the segment time as it appears in the seekbar. -->
<string name="revanced_sb_new_segment_mark_time_as_question">Set %1$02d:%2$02d:%3$03d as the start or end of a new segment?</string>
<string name="revanced_sb_new_segment_mark_time_as_question">Set %s as the start or end of a new segment?</string>
<string name="revanced_sb_new_segment_mark_start">start</string>
<string name="revanced_sb_new_segment_mark_end">end</string>
<string name="revanced_sb_new_segment_now">now</string>
Expand Down

3 comments on commit d74c366

@cyberboh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LisoUseInAIKyrios
Can not create new segment in dev.12 patches, could be caused by this commits
Screenshot_20240729_212445

@LisoUseInAIKyrios
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest dev release works for me and I can create new segemtns. Post a debug log if it's still acting up for you.

@LisoUseInAIKyrios
Copy link
Contributor Author

@LisoUseInAIKyrios LisoUseInAIKyrios commented on d74c366 Jul 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the issue is probably caused by outdated translated strings. Try again when the next dev release is built (or compile locally using the latest from dev branch). For now, setting English language for ReVanced YT will fix it.

Please sign in to comment.