chore: Use Kotlin for ReVanced API #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the motivation to rewrite it in kotlin? |
|
Personally, it makes it easier for me to maintain and reduces the amount of languages as we already use Kotlin. With our current maintainer being short on time, especially in the future, the Kotlin version will be easier to look into for me or other Kotlin devs we have |
alexandreteles
suggested changes
Feb 16, 2024
|
@alexandreteles I don't know the exact conditions for caching, headers and cors so it would be good if you can check if those are setup correctly. |
Axelen123
reviewed
Jun 29, 2024
src/main/kotlin/app/revanced/api/configuration/services/PatchesService.kt
Outdated
Show resolved
Hide resolved
Support and features are lacking
This was referenced Jul 8, 2024
This was
linked to
issues
Jul 8, 2024
Closed
oSumAtrIX
added a commit
that referenced
this pull request
Jul 9, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
oSumAtrIX
added a commit
that referenced
this pull request
Jul 9, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
oSumAtrIX
added a commit
that referenced
this pull request
Jul 9, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
oSumAtrIX
added a commit
that referenced
this pull request
Jul 9, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
oSumAtrIX
added a commit
that referenced
this pull request
Jul 9, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
oSumAtrIX
added a commit
that referenced
this pull request
Jul 9, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
oSumAtrIX
added a commit
that referenced
this pull request
Jul 10, 2024
This commit converts the entire project to a KTor project written in Kotlin. Various APIs have been updated, removed, or changed. A proxy is present to allow migration between the old and this API, which can serve requests to endpoints from the old API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR rewrites this project into Kotlin. Ktor is used for the API.
Todo before merge
Review