fixes #98: remove excessive comma in docker config that blocks it from starting #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghormoon
force-pushed
the
fix-docker-install
branch
from
8d00c05
to
8fd0f0d
Compare
…blocks it from starting, remove excessive quote in containerd config
ghormoon
force-pushed
the
fix-docker-install
branch
from
8fd0f0d
to
58e784c
Compare
ReSearchITEng
requested changes
Mar 21, 2024
ReSearchITEng
approved these changes
Mar 21, 2024
ghormoon
commented
Mar 21, 2024
| @@ -251,7 +251,7 @@ | |||
| lineinfile: | |||
| dest: /etc/containerd/config.toml | |||
| regexp: '^(.*)sandbox_image = "registry.k8s.io/pause(.*)$' | |||
| line: '\1sandbox_image = "{{ images_repo | default ("registry.k8s.io") }}/pause\2' | |||
| line: '\1sandbox_image = "{{ images_repo | default ("registry.k8s.io") }}/pause\2"' | |||
There was a problem hiding this comment.
hi, does it work for you like that? for me it creates
sandbox_image = "registry.k8s.io/pause:3.6""
unless i remove that quote.
the quote is part of the \2 backref. caught by (.*)$ on previous line. alternatively we can change the previous live to (.*)"$, does it make more sense to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing excessive comma as reported in #98
edit: added also fix for containerd config