Feature/searchbar

[GabrielMelhem]

1- Implemented searchbar
2- solve the issues
3- fix the confilcts

4- Closes #38

here it is:

[matus-vacula]

I think we don't need this file. Since you listed these packages as dependencies in package.json, they should be installed with running just npm install as it's instructed in the readme file. Or am I missing something?

[GabrielMelhem]

You are right, but I added this file to mention about the package that installed, incase someone missed to run npm install.

should i delete it ?

[orYoffe]

They would not need it, as a simple npm install would install this since the package got added to the package.json file

[GabrielMelhem]

ok i will remove it :)

[matus-vacula]

Imagine we would want to reuse this component for different purposes. Let's say searching for home and the second use case would be searching for events. In such case we wouldn't want to implement the behavior what happens here in the component but in the place where we are calling this component. The good news is that we can pass this function via a prop. You can read about props in React here https://react.dev/learn/passing-props-to-a-component
Feel free to ask questions either here or in our slack channel.

[GabrielMelhem]

Thank you for the nice advise.
i updated the component to make it more reusable (maybe :) ). hope i got it and implemented well

[matus-vacula]

Happy to see another amazing Pull Request! 🥳 Please check my comments and also it would be amazing if you could post a screenshot here in the PR whenever you're working on something visual.

[miklesch]

I can see some minor issues:

• we have two console.logs, one at searchbar and one at app. is this on purpose for something and i am not getting it?

• the two conflicting files readme and app.jsx

• styling: the labels are a bit to much at top, and on a vertical line, the labels and placeholders from input field are not matching.

• I would say, we have to place the header and the searchbar components into the root, because we need both global across the pages. but may i am wrong...

• the functionality looks good to me, but may i miss something

[GabrielMelhem]

I can see some minor issues:

• we have two console.logs, one at searchbar and one at app. is this on purpose for something and i am not getting it?
• the two conflicting files readme and app.jsx
• styling: the labels are a bit to much at top, and on a vertical line, the labels and placeholders from input field are not matching.
• I would say, we have to place the header and the searchbar components into the root, because we need both global across the pages. but may i am wrong...
• the functionality looks good to me, but may i miss something

thank you Micha for the comment
i checked the code again and solved all the points you mentioned.

i think now the ticket also ready to merge into the main branch

[miklesch]

hey gabriel,
I think you have to merge main into your branch again.
And when trying to render your component, i am getting following error:

so question is, if the package is installed in node_module, i think...

[messkalina]

hey gabriel, I think you have to merge main into your branch again. And when trying to render your component, i am getting following error:

so question is, if the package is installed in node_module, i think...

I run nmp install after checking out this branch and the Font Awesome package got installed by itself. Working fine on my mashine:

[messkalina]

The code looks good to me but there is a meging conflict. Otherwise everything looks fine to me.

[GabrielMelhem]

hey gabriel,
I think you have to merge main into your branch again.
And when trying to render your component, i am getting following error:

Hey Micha,

you should first run "npm install" to intsall the packages on your local repo also. and then run the app.

[messkalina]

All good, no hover effect on the search bar but I dont see it mentioned in the ACs so I assume it is completed as it is now.