Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endoding issues #13041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jzaprzalka
Copy link

Fixes encoding issues referenced in issue OSS-781 while running rasa data split nlu with entities containing non-english characters

Proposed changes:

  • Add ensure_ascii=False for json.dumps in TrainingDataWriter in order to properly encode non-ascii chatacters, e.g. Polish letters as referenced in issue OSS-781

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Fixes encoding issues referenced in [issue OSS-781](https://rasa-open-source.atlassian.net/browse/OSS-781) while running `rasa data split nlu` with entities containing non-english characters
@jzaprzalka jzaprzalka requested a review from a team as a code owner July 10, 2024 12:38
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants