Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag model step in CI workflow for main branch #59

Merged

Conversation

AsadHasan-Rasa
Copy link
Contributor

@AsadHasan-Rasa AsadHasan-Rasa commented Sep 18, 2024

Description

Fix tag model step in CI workflow for main branch. Just a one character change:

  1. Saw that Tag model as production step on main was failing
  2. Due to missing closing quote in the curl command
  3. ...so added the missing closing quote

Also, noticed the CI pipeline had been failing on main since beginning due to this issue:

gh run list --workflow continous-integration.yml --branch main
STATUS  TITLE                                                                   WORKFLOW                              BRANCH  EVENT  ID           ELAPSED  AGE                 
X       ENG-1293: Update rasa-calm-demo to version 3.10.1 (#58)                 Continous Integration and Deployment  main    push   10921775550  6m17s    about 33 minutes ago
X       Separate feature configurations (#42)                                   Continous Integration and Deployment  main    push   10112691035  5m1s     about 1 month ago
X       Removed unnecessary test for chitchat response at the end of another …  Continous Integration and Deployment  main    push   10003915989  5m6s     about 2 months ago
X       Merge pull request #40 from RasaHQ/qdrant-instructions                  Continous Integration and Deployment  main    push   9906813443   5m56s    about 2 months ago
X       Merge pull request #39 from RasaHQ/release-3.9                          Continous Integration and Deployment  main    push   9854050685   5m12s    about 2 months ago
X       Merge pull request #25 from RasaHQ/fix-test-run-schedule                Continous Integration and Deployment  main    push   9763077548   2m50s    about 2 months ago
X       Merge pull request #27 from RasaHQ/replace-card-using-call              Continous Integration and Deployment  main    push   9577602521   2m56s    about 3 months ago
X       Merge pull request #28 from RasaHQ/update-readme-makefile               Continous Integration and Deployment  main    push   9571996187   2m47s    about 3 months ago
X       Merge pull request #26 from RasaHQ/ENG-876-consistency-feature-comple…  Continous Integration and Deployment  main    push   9549819809   2m46s    about 3 months ago
X       Merge pull request #24 from RasaHQ/fix-test-run-schedule                Continous Integration and Deployment  main    push   9417429074   6m15s    about 3 months ago
X       Merge pull request #23 from RasaHQ/ATO-1037                             Continous Integration and Deployment  main    push   9205596678   2m23s    about 3 months ago
X       Merge pull request #20 from RasaHQ/update_rasa_version                  Continous Integration and Deployment  main    push   8736407337   2m4s     about 5 months ago
X       Merge pull request #15 from RasaHQ/sec-217                              Continous Integration and Deployment  main    push   8375308518   2m31s    about 6 months ago
X       Merge pull request #6 from RasaHQ/ENG-766-test-fixes-multi-prompting-…  Continous Integration and Deployment  main    push   8172045163   2m27s    about 6 months ago
X       Update rasa and rasa-plus to 3.7.8 (#11)                                Continous Integration and Deployment  main    push   8138146467   2m35s    about 6 months ago
X       Merge pull request #9 from RasaHQ/ENG-814-add-additional-prompts        Continous Integration and Deployment  main    push   8100773363   2m32s    about 6 months ago
X       Add info about setting up RASA_DUCKLING_HTTP_URL environment variable…  Continous Integration and Deployment  main    push   7901392994   2m27s    about 7 months ago
X       Move duckling loading to its own module (#7)                            Continous Integration and Deployment  main    push   7801559856   2m38s    about 7 months ago
X       Merge pull request #4 from RasaHQ/fix-makefile-rasa-inspect             Continous Integration and Deployment  main    push   7657210391   37s      about 7 months ago
X       Update README.md                                                        Continous Integration and Deployment  main    push   7639881280   34s      about 7 months ago

TODOs

@AsadHasan-Rasa AsadHasan-Rasa marked this pull request as ready for review September 18, 2024 12:53
@AsadHasan-Rasa AsadHasan-Rasa requested review from a team, maksim-m and djcowley and removed request for a team September 18, 2024 12:53
Copy link
Collaborator

@djcowley djcowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AsadHasan-Rasa AsadHasan-Rasa merged commit d5a6e24 into main Sep 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants