Don't mutate custom instrument list in SongResampler#applyNbsTempoCha…

…ngers
RaphiMC · Jun 30, 2024 · 75adfb6 · 75adfb6
1 parent fb6879a
commit 75adfb6
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/src/main/java/net/raphimc/noteblocklib/util/SongResampler.java b/src/main/java/net/raphimc/noteblocklib/util/SongResampler.java
@@ -18,7 +18,6 @@
 package net.raphimc.noteblocklib.util;
 
 import net.raphimc.noteblocklib.format.nbs.NbsSong;
-import net.raphimc.noteblocklib.format.nbs.model.NbsCustomInstrument;
 import net.raphimc.noteblocklib.format.nbs.model.NbsNote;
 import net.raphimc.noteblocklib.model.Note;
 import net.raphimc.noteblocklib.model.SongView;
@@ -68,14 +67,7 @@ public static void applyNbsTempoChangers(final NbsSong song) {
     public static void applyNbsTempoChangers(final NbsSong song, final SongView<NbsNote> view) {
         if (song.getHeader().getVersion() < 4) return;
 
-        boolean hasTempoChanger = false;
-        for (NbsCustomInstrument customInstrument : song.getData().getCustomInstruments()) {
-            if (customInstrument.getName().equals("Tempo Changer")) {
-                song.getData().getCustomInstruments().remove(customInstrument);
-                hasTempoChanger = true;
-                break;
-            }
-        }
+        final boolean hasTempoChanger = song.getData().getCustomInstruments().stream().anyMatch(ci -> ci.getName().equals("Tempo Changer"));
         if (!hasTempoChanger) return;
 
         final List<TempoEvent> tempoEvents = new ArrayList<>();