Minor fixes for SMSCB #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplays properly on Android devices, and corresponds to English.
…t to 0x03, corresponding to the end of the SMSCB message. GSM 04.12 Also, added SMSCB as a GSMTAP type, so it is recognized by Wireshark.
|
Hi Ervin, Nice work! Glad you could turn this into a pull request. It's a great find to have fixed. We're still trying to get CLAs automated on GitHub but until then it's a manual process. I'll e-mail you the document. |
Changed SMSCB behavior so that messages are not sent until send_time is reached.
yaka-es
pushed a commit
to yaka-es/OpenBTS
that referenced
this pull request
Nov 3, 2017
Missing step to download components
yaka-es
pushed a commit
to yaka-es/OpenBTS
that referenced
this pull request
Nov 3, 2017
…-patch-2 Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes were necessary for me to get SMSCB working properly. Props to Chuck Bokath and Donald Kirker for the discussion on OpenBTS-Discuss that led to these changes.
Changed hardcoded language code in SMSCB.cpp to 0x01, which is English in the default GSM encoding, which fixes some display errors, especially on Android phones.
The fourth L2 CBCH frame in an SMSCB message now has the Last Block Bit properly set.
GSMTAP now properly reports SMSCB messages, and Wireshark shows the messages as expected.