#85 Add configuration for ContentType #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content type default was previously set to application/x-www-form-urlencoded by default. This change allows the user to configure the contenttype via parameter in Send-SlackMessage or via the PSSlackConfig options. By default if neither are specified, the fallback is text/plain; charset=utf-8.
|
Oy, great idea, and completely missed this PR! Will check this out in the next day or two. I... don't know enough to answer this, but will switching to use utf-8 by default potentially break anything for folks out there? I might tweak this to initialize that config value as $null, and only set the parameter on invoke-restmethod if the config (or function param) specifies. It's late though and I may not be thinking clearly : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to configure the message content-type with an optional parameter or using the PSSlackConfig as requested in the linked issue.